Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Substitute ModulesCommand and SubworkflowsCommand by ComponentsCommand #2000

Merged
merged 14 commits into from
Nov 8, 2022
Merged

Substitute ModulesCommand and SubworkflowsCommand by ComponentsCommand #2000

merged 14 commits into from
Nov 8, 2022

Conversation

mirpedrol
Copy link
Member

Try removing ModulesCommand and SubworkflowsCommand and use ComponentsCommand instead as discussed in #1995(comment)

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Nov 4, 2022 •
edited
Loading

Codecov Report

Merging #2000 (4eae12d) into dev (3d0c0cc) will increase coverage by 0.73%.
The diff coverage is 71.69%.

❗ Current head 4eae12d differs from pull request most recent head 47dacd5. Consider uploading reports for the commit 47dacd5 to get more accurate results

@@            Coverage Diff             @@
##              dev    #2000      +/-   ##
==========================================
+ Coverage   63.11%   63.84%   +0.73%     
==========================================
  Files          43       41       -2     
  Lines        4945     4915      -30     
==========================================
+ Hits         3121     3138      +17     
+ Misses       1824     1777      -47
Impacted Files Coverage Δ
nf_core/components/list.py 69.62% <ø> (ø)
nf_core/components/components_command.py 70.63% <50.00%> (+2.71%) ⬆️
nf_core/modules/info.py 16.66% <66.66%> (+0.11%) ⬆️
nf_core/subworkflows/test_yml_builder.py 15.48% <66.66%> (ø)
nf_core/components/components_test.py 53.52% <100.00%> (+53.52%) ⬆️
nf_core/modules/lint/__init__.py 82.97% <100.00%> (-0.10%) ⬇️
nf_core/modules/test_yml_builder.py 49.77% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

awgymer
awgymer requested changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@awgymer awgymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update SubworkflowsTest to also use the refactored ComponentsTest class too.

Everything else is as it was after initial review so I think it's good after that?

@mirpedrol mirpedrol merged commit 5438600 into nf-core:dev Nov 8, 2022
@mirpedrol mirpedrol deleted the componentscommand branch November 8, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awgymer awgymer awgymer approved these changes

@mashehu mashehu Awaiting requested review from mashehu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirpedrol @mashehu @awgymer